Introduce orchestration versioning into worker #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halspang
force-pushed
the
halspang/worker_versioning
branch
2 times, most recently
from
541e30f to
395b4d8
Compare
cgillum
reviewed
Mar 26, 2025
cgillum
reviewed
Mar 26, 2025
cgillum
requested changes
Mar 26, 2025
Member
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
A couple of blocking issues in this PR that may require a bit of offline discussion...
halspang
force-pushed
the
halspang/worker_versioning
branch
from
9134be6 to
df22189
Compare
cgillum
reviewed
Mar 27, 2025
cgillum
reviewed
Mar 28, 2025
halspang
force-pushed
the
halspang/worker_versioning
branch
from
dacf2d9 to
2f21b3d
Compare
cgillum
approved these changes
Mar 28, 2025
Member
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
Looks good. Just a couple non-blocking comments on the test code.
This commit gives the worker several ways to configure versioning. Included are, setting the version, how to match against incoming versions, and how to react to a failed match. Signed-off-by: halspang <[email protected]>
Signed-off-by: halspang <[email protected]>
Signed-off-by: halspang <[email protected]>
halspang
force-pushed
the
halspang/worker_versioning
branch
from
2f21b3d to
e96089b
Compare
cgillum
approved these changes
Mar 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit gives the worker several ways to configure versioning. Included are, setting the version, how to match against incoming versions, and how to react to a failed match.